Merged
Conversation
Member
Author
|
I'll take a closer look tomorrow at the |
Collaborator
|
The PHP8 linter issues are fixed in #466. |
kasparsd
reviewed
Oct 12, 2022
kasparsd
reviewed
Oct 12, 2022
kasparsd
reviewed
Oct 12, 2022
Closed
These functions are either untestable in a pure unit test, or aren't worth testing. They're better suited to manual testing and e2e tests.
dc4a656 to
57506c3
Compare
Member
Author
|
I removed the commits related to |
Member
Author
|
Great, should I go ahead and merge it then? Or is there anything else we need to do first? |
Collaborator
|
Yes, please merge it in! |
Closed
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some tests to fill small gaps in coverage, and marks some functions as ignored because they're not testable in a unit test, or aren't worth testing. This increases the coverage of
class-two-factor-totp.phpto92%, making it obvious that it is well-tested.To aid in writing tests, this also adds
phpunit-watcher, similar to Gutenberg, WordCamp.org, and some other WordPress repos.See #468