Skip to content

Fix PHP8 linter#466

Merged
kasparsd merged 15 commits intomasterfrom
test/php8-compat-linte
Oct 12, 2022
Merged

Fix PHP8 linter#466
kasparsd merged 15 commits intomasterfrom
test/php8-compat-linte

Conversation

@kasparsd
Copy link
Copy Markdown
Collaborator

@kasparsd kasparsd commented Oct 7, 2022

Add back a constant that has been depracted in PHP 8 to confirm that PHPCompatibilityWP is actually working.

@kasparsd kasparsd changed the title [DO NOT MERGE] Test PHP8 linter Fix PHP8 linter Oct 7, 2022
"test": "npm-run-all test:*",
"test:php": "wp-env run phpunit 'composer test --working-dir=/var/www/html/wp-content/plugins/two-factor'",
"test:php": "npm run composer test",
"composer": "wp-env run phpunit composer --working-dir=/var/www/html/wp-content/plugins/two-factor",
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce a new script helper to run any Composer commands inside the dev environment.

@jeffpaul jeffpaul added this to the 0.9.0 milestone Oct 7, 2022
@kasparsd kasparsd marked this pull request as ready for review October 12, 2022 07:38
@kasparsd kasparsd mentioned this pull request Oct 12, 2022
@kasparsd kasparsd merged commit 2ee35c2 into master Oct 12, 2022
@kasparsd kasparsd deleted the test/php8-compat-linte branch October 12, 2022 07:44
@jeffpaul jeffpaul modified the milestones: 0.9.0, 0.8.0 Oct 12, 2022
@jeffpaul jeffpaul modified the milestones: 0.8.0, 0.7.3 Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants