This repository was archived by the owner on Jan 15, 2019. It is now read-only.
Move the fix to editor-only styles#623
Merged
Conversation
Collaborator
@allancole — It's possible you didn't see the PR, but @jasmussen and I merged that into the front end in #585 the other day. While not definitely required, it does fix some little quirks like the menu spacing noted in the PR. Since the custom font only covers one character, it should add just a couple kilobytes to the site's load. I'd prefer to keep it in, but not a huge deal either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
NonBreakingSpaceOverrideis not needed on the frontend, we shouldn’t load it at all unless we’re in the editor. This PR makes it so that fix is only added to the Gutenberg editor, which will make ourstyle.cssfile a good bit lighter on the front end. It also removes a duplicatecolors.scssinclude.