This repository was archived by the owner on Jan 15, 2019. It is now read-only.
Try: Use non-breaking space override globally#585
Merged
Conversation
jasmussen
approved these changes
Nov 14, 2018
Collaborator
jasmussen
left a comment
There was a problem hiding this comment.
I think this is good. Ship it.
Even if the fix can be further improved or even deprecated at some point, this consistency will be a good start.
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup to #463.
This PR takes the
font override from our editor styles and applies it to the front end as well. It aligns the width of Hoefler Text non-breaking spaces in Chrome with their width in other browsers, and if all goes well, it should have no effect on the front end except when viewing a site in Chrome on a Mac.In that case, you'll notice that
 characters are shorter. For instance, nested submenu items will appear differently:Before
After
