This repository was archived by the owner on Jan 15, 2019. It is now read-only.
General code and documentation improvements#546
Merged
allancole merged 20 commits intoWordPress:masterfrom Nov 27, 2018
grappler:general-patches
Merged
General code and documentation improvements#546allancole merged 20 commits intoWordPress:masterfrom grappler:general-patches
allancole merged 20 commits intoWordPress:masterfrom
grappler:general-patches
Conversation
WPprodigy
reviewed
Nov 11, 2018
As listed as TODO
Define default $primary_color and change if colorscheme is not default
# Conflicts: # functions.php # inc/color-patterns.php # inc/template-functions.php
Member
Author
|
@allancole I have fixed the code conflicts again. Is there a reason that the PR has not been reviewed yet. I am happy to move any commits to their own PR if you feel they need to be discussed further. |
Went ahead and resynced this to the master branch so we can commit a patch to Trac for 5.0
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Dec 14, 2018
This change adds general code quality and documentation improvements. - More info here: WordPress/twentynineteen#546 Props grapplerulrich, iCaleb. git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44187 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 15, 2018
This change adds general code quality and documentation improvements. - More info here: WordPress/twentynineteen#546 Props grapplerulrich, iCaleb. Built from https://develop.svn.wordpress.org/branches/5.0@44187 git-svn-id: http://core.svn.wordpress.org/branches/5.0@44017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Dec 15, 2018
This change adds general code quality and documentation improvements. - More info here: WordPress/twentynineteen#546 Props grapplerulrich, iCaleb. Built from https://develop.svn.wordpress.org/branches/5.0@44187 git-svn-id: https://core.svn.wordpress.org/branches/5.0@44017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Dec 18, 2018
This change adds general code quality and documentation improvements. More info here: WordPress/twentynineteen#546 Props grapplerulrich, iCaleb, allancole. Merges [44187] to trunk. See #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44298 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Dec 18, 2018
This change adds general code quality and documentation improvements. More info here: WordPress/twentynineteen#546 Props grapplerulrich, iCaleb, allancole. Merges [44187] to trunk. See #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44298 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 19, 2018
This change adds general code quality and documentation improvements. More info here: WordPress/twentynineteen#546 Props grapplerulrich, iCaleb, allancole. Merges [44187] to trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44298 git-svn-id: http://core.svn.wordpress.org/trunk@44128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Dec 19, 2018
This change adds general code quality and documentation improvements. More info here: WordPress/twentynineteen#546 Props grapplerulrich, iCaleb, allancole. Merges [44187] to trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44298 git-svn-id: https://core.svn.wordpress.org/trunk@44128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
svn2github
pushed a commit
to svn2github/wp-svn-2-git
that referenced
this pull request
Dec 21, 2018
This change adds general code quality and documentation improvements. More info here: WordPress/twentynineteen#546 Props grapplerulrich, iCaleb, allancole. Merges [44187] to trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44298 git-svn-id: http://core.svn.wordpress.org/trunk@44128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going through the code I found a few places where the code or the documentation could be improved. For each point that I found I made a separate commit.
There should not be anything controversial.
Happy to answer anything if the commit messages are not clear.