Skip to content

Revert "Allow a prop format to be specified"#63

Merged
aaronjorbin merged 1 commit intotrunkfrom
revert-61-feature/allow-choice-of-format
Feb 6, 2024
Merged

Revert "Allow a prop format to be specified"#63
aaronjorbin merged 1 commit intotrunkfrom
revert-61-feature/allow-choice-of-format

Conversation

@aaronjorbin
Copy link
Copy Markdown
Member

Reverts #61

This is causing failures, reverting so it can be further investigated. See: https://github.com/WordPress/gutenberg/actions/runs/7806504966/job/21293004833?pr=58107

@aaronjorbin aaronjorbin requested a review from jeffpaul February 6, 2024 21:48
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorbin, dmsnell, jeffpaul.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: dmsnell <dmsnell@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Copy Markdown
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revert.

@aaronjorbin aaronjorbin merged commit 3a82c84 into trunk Feb 6, 2024
@aaronjorbin aaronjorbin deleted the revert-61-feature/allow-choice-of-format branch February 6, 2024 21:53
aaronjorbin added a commit that referenced this pull request Feb 8, 2024
Take 2.  

Fixes #38, #47.
See: #61, #63.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants