Conversation
jorgefilipecosta
approved these changes
Sep 25, 2018
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Implements the desired behaviour in my tests 👍
|
|
||
| // Native inputs should not navigate horizontally. | ||
| const { tagName } = element; | ||
| return tagName !== 'INPUT' && tagName !== 'TEXTAREA'; |
Member
There was a problem hiding this comment.
Would it make sense to apply this to all the editables?
Member
Author
There was a problem hiding this comment.
Can you elaborate on what you mean? Are you thinking to reverse this condition so that we test whether the candidate is explicitly contentEditable ? Or do you mean we should include editables In the excluded set of candidates? That would cause issues for navigating between paragraphs, where we do want ArrowRight to navigate between blocks.
e556b61 to
5a096c6
Compare
5a096c6 to
10902b6
Compare
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6468
This pull request seeks to update the writing flow behavior to allow only unmodified vertical arrow key presses for consideration in a browser native input (textarea, input).
Testing instructions:
Verify that horizontally navigating between non-input fields still works.
Verify that only unmodified vertical arrow press in native input transitions focus:
Ensure unit tests and end-to-end tests pass: