Conversation
Contributor
|
Nice! Works pretty well, especially for the prototype. The controls jittered a bit vertically for me, e.g. try to first right align, then left align, and the controls would be vertically off. But selecting another block, then the image again, fixed that right up. |
Member
|
Next step is repositioning the block move controls :) |
Contributor
Author
Indeed I was having the same issues. I think it is a timing thing with the image block resizing/moving. Another issue is resizing the browser window - the block controls stay fixed since we don't listen to window resize events. But for the sake of the prototype it seems to work "well enough" |
nylen
pushed a commit
that referenced
this pull request
Mar 16, 2017
Attempt to make controls appear in the correct spot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92 - This solution is not perfect, but it does get the controls to flow around much better when aligning images. Currently there is still some weirdness if you continually toggle alignments in rapid succession. I started to even play with
setTimeouta bit but realized that might be overkill for the UI prototype.So... to test this out, interact with the image align controls. Specifically go from "normal" to "right", and to full bleed. For best results, focus on a different block between those two ;)