Backport: Improve validation and permission checks for WP_HTTP_Polling_Sync_Server#76987
Merged
peterwilsoncc merged 2 commits intotrunkfrom Apr 2, 2026
Merged
Backport: Improve validation and permission checks for WP_HTTP_Polling_Sync_Server#76987peterwilsoncc merged 2 commits intotrunkfrom
WP_HTTP_Polling_Sync_Server#76987peterwilsoncc merged 2 commits intotrunkfrom
Conversation
…g_Sync_Server Backport of WordPress/wordpress-develop#11296. Hardens WP_HTTP_Polling_Sync_Server endpoints with additional validation and permission checks: - Add MAX_BODY_SIZE, MAX_ROOMS_PER_REQUEST, MAX_UPDATE_DATA_SIZE constants - Add maxLength constraint for update data strings - Add maxItems constraint for rooms per request - Add route-level validate_callback for request body size - Improve can_user_sync_entity_type() to use ctype_digit() for object ID validation, verify post type matches, validate taxonomy terms exist in the correct taxonomy, and reject zero/negative object IDs - Add comprehensive test coverage for new validation and permission checks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 521da9e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23879753130
|
peterwilsoncc
approved these changes
Apr 2, 2026
Contributor
peterwilsoncc
left a comment
There was a problem hiding this comment.
Thanks Chris, this matches the changes in the WordPress-Develop repo.
gutenbergplugin
pushed a commit
that referenced
this pull request
Apr 2, 2026
…ng_Sync_Server` (#76987) * Backport: Improve validation and permission checks for WP_HTTP_Polling_Sync_Server Backport of WordPress/wordpress-develop#11296. Hardens WP_HTTP_Polling_Sync_Server endpoints with additional validation and permission checks: - Add MAX_BODY_SIZE, MAX_ROOMS_PER_REQUEST, MAX_UPDATE_DATA_SIZE constants - Add maxLength constraint for update data strings - Add maxItems constraint for rooms per request - Add route-level validate_callback for request body size - Improve can_user_sync_entity_type() to use ctype_digit() for object ID validation, verify post type matches, validate taxonomy terms exist in the correct taxonomy, and reject zero/negative object IDs - Add comprehensive test coverage for new validation and permission checks * Add backport changelog --------- Co-authored-by: chriszarate <czarate@git.wordpress.org> Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: cd91928 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Hardens WP_HTTP_Polling_Sync_Server endpoints with additional validation and permission checks.
Why?
Backport of WordPress/wordpress-develop#11296
How?