Upgrade actionlint and run linting when composite actions are modified#76503
Merged
Upgrade actionlint and run linting when composite actions are modified#76503
Conversation
7587779 to
5f7a4fa
Compare
1e3d30e to
49fe380
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 49fe380. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23079489618
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The changes in #76492 surfaced a failure in an
action.ymlfile within thepackagesdirectory. Those files are not currently trigger a scan, so the linting workflow did not detect them in the pull request.Upgrading
actionlintsolves this issue, but flags several new issues due to the introduction of new checks.The majority of these are within the React Native-related workflows and jobs. With the update to React 19, the unit tests are breaking and have been disabled (see #71337). The
if: falsepattern is also flagged byactionlint. The mobile testing workflows for iOS and Android have also been disabled entirely for some time.If these are needed in the future, they can always be recovered through version control.
I've removed the
Mobilejob as a required check. Since it never runs, requiring it is unnecessary.Why?
It's important to have passing linting reports.
Use of AI Tools
Claude was used to create an initial PR.