Skip to content

Update Node version to v24 for flaky test reporter#76492

Merged
Mamaduka merged 1 commit intotrunkfrom
update/flaky-test-reporter
Mar 13, 2026
Merged

Update Node version to v24 for flaky test reporter#76492
Mamaduka merged 1 commit intotrunkfrom
update/flaky-test-reporter

Conversation

@Mamaduka
Copy link
Copy Markdown
Member

@Mamaduka Mamaduka commented Mar 13, 2026

What?

This is similar to #62401.

PR updates the Node version for the flaky test reporter action.

Why?

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: ./packages/report-flaky-tests. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Testing Instructions

It shouldn't generate a notice in the e2e tests summary after the PR is merged.

@Mamaduka Mamaduka self-assigned this Mar 13, 2026
@Mamaduka Mamaduka requested a review from kevin940726 as a code owner March 13, 2026 15:11
@Mamaduka Mamaduka added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Mar 13, 2026
@Mamaduka Mamaduka requested a review from desrosj March 13, 2026 15:11
desrosj
desrosj approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mamaduka!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka enabled auto-merge (squash) March 13, 2026 15:16
@Mamaduka Mamaduka merged commit 74b11a6 into trunk Mar 13, 2026
47 of 48 checks passed
@Mamaduka Mamaduka deleted the update/flaky-test-reporter branch March 13, 2026 15:49
@github-actions github-actions bot added this to the Gutenberg 22.8 milestone Mar 13, 2026
@manzoorwanijk
Copy link
Copy Markdown
Member

manzoorwanijk commented Mar 13, 2026

This seems to be causing actionlint to fail https://github.com/WordPress/gutenberg/actions/runs/23059755236/job/66982848646?pr=75814

@Mamaduka
Copy link
Copy Markdown
Member Author

Mamaduka commented Mar 13, 2026 •
edited
Loading

Odd, docs say node24 is supported - https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax#runs-for-javascript-actions. Maybe the actionlint also needs an update.

Do you know why the error wasn't caught here?

P.S. If the error is blocking work, feel free to revert, and I'll have a proper look tomorrow or Monday.

Update: It seems to be passing on trunk and other PRs.

@manzoorwanijk
Copy link
Copy Markdown
Member

manzoorwanijk commented Mar 14, 2026

Update: It seems to be passing on trunk and other PRs.

Because that action runs only when someone touches the workflows

gutenberg/.github/workflows/workflow-lint.yml

Lines 8 to 9 in 7f3500a

# Only run when changes are made to workflow files.
- '.github/workflows/**'

@desrosj
Copy link
Copy Markdown
Member

desrosj commented Mar 14, 2026

So actionlint is outdated, and it does appear that this issue is resolved after updating. However, there are some new issues that are introduced. PR incoming.

@desrosj desrosj mentioned this pull request Mar 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desrosj desrosj desrosj approved these changes

@kevin940726 kevin940726 Awaiting requested review from kevin940726 kevin940726 is a code owner

Assignees

@Mamaduka Mamaduka

Labels

[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Milestone

Gutenberg 22.8

Development

Successfully merging this pull request may close these issues.

3 participants

@Mamaduka @manzoorwanijk @desrosj