Check for IS_WORDPRESS_CORE before npm_package_config_IS_WORDPRESS_CORE#76334
Merged
Check for IS_WORDPRESS_CORE before npm_package_config_IS_WORDPRESS_CORE#76334
IS_WORDPRESS_CORE before npm_package_config_IS_WORDPRESS_CORE#76334Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dmsnell
approved these changes
Mar 10, 2026
Member
dmsnell
left a comment
There was a problem hiding this comment.
Good catch.
Do we need to indicate, or want to log() anything if these are in disagreement? seems like a basic log line could be useful if both are present but not both the same.
|
Size Change: 0 B Total Size: 6.89 MB ℹ️ View Unchanged
|
Member
Author
I think that could be useful for some scenarios. It should be added to each instance and not just this one. I made a note to follow up with a separate PR after finishing up the |
|
Flaky tests detected in f66aefa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22882366423
|
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 10, 2026
In #76038, code was added to exclude experimental pages when building for WordPress Core. The code merged in #75844 did not adjust this code to detect the environment variable `IS_WORDPRESS_CORE` before `npm_package_config_IS_WORDPRESS_CORE`. Co-authored-by: desrosj <desrosj@git.wordpress.org> Co-authored-by: dmsnell <dmsnell@git.wordpress.org>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: f290e6c |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 10, 2026
This updates the pinned hash from the `gutenberg` from `7b7fa2bc97a8029a302bd6511cf0d206b5953172` to `9b8144036fa5faf75de43d4502ff9809fcf689ad`. The following changes are included: - Use V2 Yjs methods for HTTP Polling (WordPress/gutenberg#76304) - Plugin: Include Icons assets in ZIP (WordPress/gutenberg#75866) - Ensure consistent, repeatable build results when inlining WASM files via `wasmInlinePlugin` (WordPress/gutenberg#76113) - Account `IS_WORDPRESS_CORE` is set. (WordPress/gutenberg#76334) - Block Visibility: Add `fetchpriority=auto` to `IMG` tags in blocks with conditional viewport visibility to prevent potential erroneous high loading priority (WordPress/gutenberg#76302) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/7b7fa2bc97a8029a302bd6511cf0d206b5953172…9b8144036fa5faf75de43d4502ff9809fcf689ad. See #64595, #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61870 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 10, 2026
This updates the pinned hash from the `gutenberg` from `7b7fa2bc97a8029a302bd6511cf0d206b5953172` to `9b8144036fa5faf75de43d4502ff9809fcf689ad`. The following changes are included: - Use V2 Yjs methods for HTTP Polling (WordPress/gutenberg#76304) - Plugin: Include Icons assets in ZIP (WordPress/gutenberg#75866) - Ensure consistent, repeatable build results when inlining WASM files via `wasmInlinePlugin` (WordPress/gutenberg#76113) - Account `IS_WORDPRESS_CORE` is set. (WordPress/gutenberg#76334) - Block Visibility: Add `fetchpriority=auto` to `IMG` tags in blocks with conditional viewport visibility to prevent potential erroneous high loading priority (WordPress/gutenberg#76302) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/7b7fa2bc97a8029a302bd6511cf0d206b5953172…9b8144036fa5faf75de43d4502ff9809fcf689ad. See #64595, #64393. Built from https://develop.svn.wordpress.org/trunk@61870 git-svn-id: http://core.svn.wordpress.org/trunk@61157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In #76038, code was added to exclude experimental pages when building for WordPress Core.
The code merged in #75844 did not adjust this code to detect the environment variable
IS_WORDPRESS_COREbeforenpm_package_config_IS_WORDPRESS_CORE.Why?
This ensures that the environment variable it can be easily set through a CI workflow.