DataViews: Fix focus transfer while searching in list layout#75999
Merged
Conversation
|
Size Change: +67 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
list layoutlist layout
8bc4fde to
6c710cc
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Feb 27, 2026
Mamaduka
left a comment
Member
There was a problem hiding this comment.
Thanks, Nik!
The fix to avoid focus shift makes sense. I was able to reproduce the bug and confirm it's fixed now.
6c710cc to
dfba6db
Compare
gziolo
pushed a commit
that referenced
this pull request
Mar 3, 2026
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: mecskyverse <aakashverma1@git.wordpress.org> Co-authored-by: allilevine <firewatch@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #67758
Alternative of: #71810
In
listlayout of DataViews sometimes there is a focus transfer while searching. The issue cannot be reproduced consistently in 'real' usage because of racing conditions between Ariakit's removal/set of active composite item and our own updating of that. I've added an e2e test for that.The main issue was setting focus to the active list item unconditionally when selecting a new active composite item. That was problematic because while it's fine to keep setting the active item id to a new item if the previous active item was removed from the list, but focus should only update if our above programmatic selection came from within the composite itself (keyboard navigation, etc..).
Testing Instructions
Results might be inconsistent, but I could reproduce 'reliably' if I typed fast :)
pagespage in list layoutBefore
before.mov
After
Screen.Recording.2026-02-27.at.12.50.26.PM.mov