Skip cross origin isolation e2e tests#75764
Conversation
… suite instead, that way we can continue testing that the feature works
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
|
Okay, it's just the flaky undo e2e test that's failing now, so I'm going to merge this in without waiting for requirements to be met. Thanks again for all the help with these e2e tests and PRs today @Mamaduka, I appreciate it! I'm off for the week, but if there's still any weirdness with the tests, happy to follow-up on Monday. |
|
Thanks, @andrewserong! |
* Temporarily skip cross origin isolation e2e tests * Try enabling the client side media processing experiment for this e2e suite instead, that way we can continue testing that the feature works * Skip cross-origin isolation suite instead Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
* Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
* Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
* Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
* Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
* Client-side media processing: Disable in Gutenberg just for now (#75756) * Client-side media processing: Disable in Gutenberg just for now * Try to fix failing test * Update docblock Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> * Re-enable client-side media processing (#75848) * Re-enable client-side media processing in the Gutenberg plugin Remove the disabling shim that was added in #75756, re-enable the cross-origin isolation e2e tests skipped in #75764, and add thorough e2e tests for client-side media filename handling, scaled image metadata, and thumbnail generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove e2e test changes from this PR The improved e2e tests for file naming belong in #75817 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Clean up dead bootstrap filter refs in tests The bootstrap override for client-side media processing was removed, but tests still referenced it with remove_filter / add_filter calls. Also replaces redundant "can be enabled" test with a "can be disabled via filter" test. --------- Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Alternative to #75763
Follows:
Just skip the cross-origin isolation tests for now.
Why?
With #75756 we're defaulting to the client-side media processing feature being disabled.
We can re-enable these tests when re-enabling the feature.