Sort registry files by handle/ID.#75755
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
|
you might have to rebase the PR to get rid of the e2e test failures. |
4c6ce1d to
679f156
Compare
|
Thanks @youknowriad, that did the trick with the E2E tests. I've tested the build in wp-dev with this branch's commit hash checked out at the build is working as expected. For testing purposes, I confirmed I could manipulate the preferences within the post editor interface as |
|
I'm working to get the build script output as reproducible as possible in Just to make sure I am not missing something. Is there any reason why this cannot be merged into |
|
@desrosj Good catch, no reason, we missed adding the backport label, that's all. |
Modifies the generated script, script module and style registry files to sort the files alphabetically via the assets name. This ensures the order of these assets is deterministic rather than based on the, potentially random, order of operations. This serves two purposes: * reduces the diff in the WordPress build server's commit log to just files that have changed, * ensures the registry files are not included in update packages due to randomness rather than substantive changes. Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: cde45ea |
This updates the pinned hash from the `gutenberg` from `f4d8a5803aa2fbe26e7d9af4d17e80a622b7bab8` to `7b7fa2bc97a8029a302bd6511cf0d206b5953172`. The following changes are included: - Sort registry files by handle/ID. (WordPress/gutenberg#75755) - Obey undoIgnore flag in editEntityRecord (WordPress/gutenberg#76206) - RTC: Fix `post-editor-template-mode` E2E test (WordPress/gutenberg#76209) - Publish built Gutenberg plugin to the GitHub Container Registry (WordPress/gutenberg#75844) (WordPress/gutenberg#76273) - Connectors: Improve placeholder text and make it translatable (WordPress/gutenberg#75996) - Block context menu: context menu not closing for disconnecting unsynced pattern menu items (WordPress/gutenberg#75405) - Connectors: Improve responsive layout for small viewports (WordPress/gutenberg#76231) - theme.json schema: fix pseudo-class definition for button block (WordPress/gutenberg#76272) - Navigation block: fix submenu chevron toggle on touch devices (WordPress/gutenberg#76197) See #64595, #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61868 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `f4d8a5803aa2fbe26e7d9af4d17e80a622b7bab8` to `7b7fa2bc97a8029a302bd6511cf0d206b5953172`. The following changes are included: - Sort registry files by handle/ID. (WordPress/gutenberg#75755) - Obey undoIgnore flag in editEntityRecord (WordPress/gutenberg#76206) - RTC: Fix `post-editor-template-mode` E2E test (WordPress/gutenberg#76209) - Publish built Gutenberg plugin to the GitHub Container Registry (WordPress/gutenberg#75844) (WordPress/gutenberg#76273) - Connectors: Improve placeholder text and make it translatable (WordPress/gutenberg#75996) - Block context menu: context menu not closing for disconnecting unsynced pattern menu items (WordPress/gutenberg#75405) - Connectors: Improve responsive layout for small viewports (WordPress/gutenberg#76231) - theme.json schema: fix pseudo-class definition for button block (WordPress/gutenberg#76272) - Navigation block: fix submenu chevron toggle on touch devices (WordPress/gutenberg#76197) See #64595, #64393. Built from https://develop.svn.wordpress.org/trunk@61868 git-svn-id: http://core.svn.wordpress.org/trunk@61155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
What?
Sorts script and style registry files by handle; sorts modules registry file by ID.
Why?
This ensures the diff in the built version of WordPress is showing just the effected files rather than affected by order of operations.
How?
Adding sort statements to the beginning of the
generate*RegistrationPhpfunctions.Testing Instructions
This is modifying the WordPress build so will need to be checked in WordPress-Develop.
As these are using
wp_register_*functions, the final step should be fine but will need verification.While testing I ran the following as an mu-plugin at the files were output in the expected order:
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A