Packages: Move packages repository into Gutenberg#7556
Conversation
Add the WordPress hook library from 21170-core in preparation for beta npm release
…-hooks Correctly enable dashes in regexes in validateNamespace
Questionable value of the test assertions, which are specific to the implementation and not the expected intent of the test case
# Conflicts: # packages/hooks/src/test/index.test.js # packages/hooks/src/validateNamespace.js
test/unit/jest.config.json
Outdated
| "@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-data|core-blocks|nux)$": "$1", | ||
| "@wordpress\\/(api-request|blob|core-data|data|date|dom|deprecated|element|plugins|postcss-themes)$": "packages/$1/src" | ||
| "@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-blocks|nux)$": "$1", | ||
| "@wordpress\\/(browserslist-config)$": "packages/$1", |
There was a problem hiding this comment.
We probably don't need this line anymore.
| "@wordpress\\/(api-request|blob|core-data|data|date|dom|deprecated|element|plugins|postcss-themes)$": "packages/$1/src" | ||
| "@wordpress\\/(blocks|components|editor|utils|edit-post|viewport|core-blocks|nux)$": "$1", | ||
| "@wordpress\\/(browserslist-config)$": "packages/$1", | ||
| "@wordpress\\/(.*)$": "packages/$1/src" |
There was a problem hiding this comment.
@aduth @youknowriad - do we want to run our tests against src, build or build-module? What if we provide src locally and build-module on Travis?
There was a problem hiding this comment.
I think we should only run src for both.
|
Unit tests fail because of the following issue: jestjs/jest#4407:
There is a workaround proposed: However, it still fails for us with a really interesting output:
In particular |
WordPress archived the packages repo and moved everything into the Gutenberg Project. See: WordPress/packages@5e4f4f4 WordPress/gutenberg#7556
Description
Adds https://github.com/WordPress/packages/ including all commit history to Gutenberg.
Once this is merged, we need to start moving over issues and PR's from the old repo to Gutenberg as well.
How has this been tested?
I have only tested the script for creating symlinks. Hoping @gziolo could take over from here. 😄
Types of changes
I ran
git subtree add --prefix temp-packages https://github.com/WordPress/packages.git masterto preserve the commit history. Then I moved the files over to the right directories, synchronized the config files and scripts and removed what was no longer needed.Checklist: