Image Block: Handle image URLs without protocol#75135
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +89 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Feb 2, 2026
Comment on lines
+323
to
+326
| // Handle URLs without protocol. | ||
| const normalizedNewURL = getProtocol( newURL ) | ||
| ? newURL | ||
| : prependHTTPS( newURL ); |
Member
There was a problem hiding this comment.
I think the prepend methods already check and bail out early, if URL has protocol.
Member
Author
There was a problem hiding this comment.
I thought so too, but I couldn't find that:
prependHTTPS()bails only if the URL starts withhttp://and falls back toprependHTTPprependHTTP()will allow any usable "URL", allowing relative paths like#aboutor?page=1
So I thought it's best to bet on the safe side.
Member
There was a problem hiding this comment.
Good point. I wonder if similar early fallback is worth adding to this methods.
Member
Author
There was a problem hiding this comment.
Maybe. Worth checking all the usage before making a call, though.
Member
Author
|
Thanks for the quick look, @Mamaduka 🙌 |
adamsilverstein
pushed a commit
that referenced
this pull request
Feb 3, 2026
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
MaggieCabrera
pushed a commit
that referenced
this pull request
Feb 10, 2026
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Handle image URLs without protocol when inserting from URL in the Image block.
The last part of #74738.
Why?
Currently, if the user inputs a URL without a protocol, it won't load.
See #74738.
Originally #74738 reported the bug for both blocks, and #74964 only fixed it for the Video block, so this one fixes it for the Image block.
How?
We're prepending HTTPS to the URL when necessary.
Also adding a simple e2e test for this behavior.
Testing Instructions
Test instructions:
Testing Instructions for Keyboard
Same
Screenshots or screencast
Nothing was visibly changed.