The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: +318 B (+0.01%)

Total Size: 3 MB

_{compressed-size-action}

This feels like an improvement to me, but I recognise it's a big change so am keen to get wider feedback.

One small feedback; if a view supplies a media field I think we should consider locking it's visibility in Grid layout. I can't really think of a scenario where hiding the media field in Grid layout makes sense. Similarly, if a user hides the media field in a layout like Table, it seems reasonable to reveal it automatically when they switch to Grid.

Thanks for the ping! Conceptually and code-wise I really like this idea, as it simplifies things a bit, and I agree that most use cases for Grid will be centered around the preview / media field 👍

The one case I could think of where folks might find it unexpected that you can't hide the media field is if there's anyone currently using the grid layout for something like the following where the description field is the prominent one. Here's how folks (might) use it, based on the templates screen:

I feel like we might have discussed that in the past somewhere, I wonder if @oandregal remembers.

All that said, being slightly more opinionated about the Grid layout and effectively saying this layout is for a grid with a media/preview field does make sense to me.

but I recognise it's a big change so am keen to get wider feedback.

Me too, I wonder if there are other projects using DataViews with the Grid layout, where folks might give feedback? I'm pretty biased as I've mostly been focused on media, so for my own use cases this change looks great 😄

One small feedback; if a view supplies a media field I think we should consider locking it's visibility in Grid layout. I can't really think of a scenario where hiding the media field in Grid layout makes sense. Similarly, if a user hides the media field in a layout like Table, it seems reasonable to reveal it automatically when they switch to Grid.

I'm not really sure layouts should contain such logic for smart showing/hiding fields etc.. If you look at the storybook, no layout has constraints about any field (title, media, description, etc..) and I believe that's intentional in order to be able to switch layouts seamlessly.

If for a consumer a field is important, it should not be hideable in general. That's my 2 cents though 😄

@ntsekouras I don't disagree, but unless I'm missing something the motivation to hide the media field would generally be to create a denser view, but that isn't really achieved due to the placeholder.

Maybe we can address that by adjusting the aspect ratio to make the placeholder smaller e.g.:

the motivation to hide the media field would generally be to create a denser view, but that isn't really achieved due to the placeholder.

That's fair enough. I updated to have a smaller placeholder.