Remove unnecessary async keywords from WASM inlining test callbacks#74636
Merged
adamsilverstein merged 2 commits intoJan 15, 2026
Conversation
Co-authored-by: adamsilverstein <2676022+adamsilverstein@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on adding @wordpress/worker-threads package migration
Remove unnecessary async keywords from WASM inlining test callbacks
Jan 15, 2026
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
6669437
into
feature/74352-new-wordpress-vips-package-no-shopify
27 of 34 checks passed
|
Size Change: 0 B Total Size: 3.05 MB ℹ️ View Unchanged
|
adamsilverstein
added a commit
that referenced
this pull request
Jan 20, 2026
…74636) * Initial plan * Remove unnecessary async keywords from test callbacks Co-authored-by: adamsilverstein <2676022+adamsilverstein@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: adamsilverstein <2676022+adamsilverstein@users.noreply.github.com>
adamsilverstein
added a commit
that referenced
this pull request
Feb 2, 2026
…74636) * Initial plan * Remove unnecessary async keywords from test callbacks Co-authored-by: adamsilverstein <2676022+adamsilverstein@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: adamsilverstein <2676022+adamsilverstein@users.noreply.github.com>
adamsilverstein
added a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Feb 24, 2026
…ordPress#74636) * Initial plan * Remove unnecessary async keywords from test callbacks Co-authored-by: adamsilverstein <2676022+adamsilverstein@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: adamsilverstein <2676022+adamsilverstein@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #74629 regarding unnecessary
asynckeywords in test callbacks that don't useawait.Changes
asyncfrom four test callbacks intest/e2e/specs/editor/various/wasm-inlining.spec.js(lines 33, 41, 49, 57)All four test functions only perform synchronous operations (reading
buildContentfrombeforeAlland executingexpectassertions), making theasynckeyword redundant.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.