You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@manzoorwanijk I'm trying to do the same as #70838 for the registry-provider section. Is there a source you used for the official types? My main concern are functions like resolveSelect and getResolveSelectors. At present, they're untyped and appear to be optional as a result, but the code seems to assume that they are present.
There are also some conflicting functions like useDispatch() supposedly returning useRegistry().dispatch while having an incompatible type.
There's also the undefined/unknown vs throwing something issue - adding types to these functions will break pretty much everything that references the @wordpress/data package.
(If this counts as stepping on toes, I'll drop it - I haven't done much beyond porting some work I did a while ago for some stuff I was testing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Converts the registry-related files in @wordpress/data to TypeScript
Why?
This is a step to fully converting the codebase to typescript.
How?
By converting some of the files to typescript.