TypeScript: Convert data controls to TS#70838
Closed
manzoorwanijk wants to merge 3 commits into
Closed
Conversation
|
Size Change: 0 B Total Size: 3.09 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 463a478. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19095424640
|
51084bd to
004a1c5
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
004a1c5 to
093b206
Compare
SirLouen
reviewed
Jan 18, 2026
| * @property {Function} dispatch Given a namespace key, returns an | ||
| * object of the store's registered | ||
| * action dispatchers. | ||
| * @property {any} stores An object of registered stores. |
Member
There was a problem hiding this comment.
Looking through packages/data/src/types.ts I would say that better than any I would rather choose some combination extending StoreInstance or maybe something a little more generic?
But I feel that any is too loose for this case.
Member
Author
There was a problem hiding this comment.
The registry is still too far from better typing. I wanted to actually use unknown here, but that opens a can of worms. So, I used any here to keep things moving. Once, registry is properly typed this will automatically be updated.
Member
Author
|
Completed via #76149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Converts several JavaScript files in the
@wordpress/datapackage to TypeScript.Why?
This is part of the ongoing effort (via #67691) to improve type safety and developer experience in the Gutenberg codebase by migrating JavaScript files to TypeScript.
How?
Converted the following files from JavaScript to TypeScript:
controls.js→controls.ts: Added types for theselect,resolveSelect, anddispatchcontrol functions, including proper typing forStoreDescriptorparameters and control arguments (SelectorControlArgs,ActionControlArgs).promise-middleware.js→promise-middleware.ts: Added the ReduxMiddlewaretype annotation.resolvers-cache-middleware.js→resolvers-cache-middleware.ts: Added types for the registry parameter (WPDataRegistry), store name, and the resolver entries map.Testing Instructions
npm run clean:package-types && npm run buildto verify the build succeeds.Testing Instructions for Keyboard
N/A - No UI changes.
Screenshots or screencast
N/A - Internal code changes only.