74421 configure build pipeline#74426
Merged
adamsilverstein merged 8 commits intoJan 8, 2026
Merged
Conversation
|
Size Change: 0 B Total Size: 3.08 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
Adding @youknowriad to review the approach here |
adamsilverstein
commented
Jan 8, 2026
| if ( fileName.endsWith( 'vips.wasm' ) ) { | ||
| fileName = VipsModule; | ||
| return VipsModule; | ||
| } else if ( fileName.endsWith( 'vips-heif.wasm' ) ) { |
Member
Author
There was a problem hiding this comment.
@swissspidy Should we just leave off libheif/vips-heif.wasm here for now to avoid the licensing issues?
Member
There was a problem hiding this comment.
SGTM. That would make the bundle smaller too.
2115d9f
into
feature/74352-new-wordpress-vips-package
37 checks passed
adamsilverstein
added a commit
that referenced
this pull request
Jan 8, 2026
This reverts commit 2115d9f.
jsnajdr
reviewed
Jan 9, 2026
jsnajdr
left a comment
Member
There was a problem hiding this comment.
I'm curious where this package is used and how did it work before this patch.
Esbuild doesn't handle .wasm out of the box, so it probably failed with error when encountering the import 'wasm-vips/vips.wasm' statement.
Webpack converts the import to an async module and generates a .wasm asset with its own URL. That's something we want to prevent with this PR, for compat reasons.
We should be careful about how we load and use the vips package now. The built index.mjs file is now 17MB, because it inlines all the WASM data. When there's no longer async loading in place, we should somehow provide it ourselves.
| // Handle imports like 'wasm-vips/vips.wasm'. | ||
| if ( ! args.path.startsWith( '.' ) ) { | ||
| const { createRequire } = await import( 'module' ); | ||
| const require = createRequire( args.resolveDir + '/index.js' ); |
Member
There was a problem hiding this comment.
This code should use esbuild's own resolver, with build.resolve. We have an existing example in the externalizeAllExceptCssPlugin, which also prevents loops.
I have some doubts whether we need this onResolve callback at all. Esbuild should be able to do the *.wasm resolution on its own, and then we only need a onLoad( { filter: /\.wasm$/ } ) callback that does the custom loading.
Or maybe we don't need any callbacks at all, not even onLoad, and the entire job can be achieved with an esbuild option:
loader: { '.wasm': 'dataurl' }
Member
It wasn't properly used before AFAIK. I added the initial version for the experimental client-side media processing but hadn't glued it to the media upload logic so far. |
adamsilverstein
added a commit
that referenced
this pull request
Jan 20, 2026
* Add wasmInlinePlugin to inline vips * Add wasm inlining tests * doc blocks
adamsilverstein
added a commit
that referenced
this pull request
Feb 2, 2026
* Add wasmInlinePlugin to inline vips * Add wasm inlining tests * doc blocks
adamsilverstein
added a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Feb 24, 2026
* Add wasmInlinePlugin to inline vips * Add wasm inlining tests * doc blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR configures the build pipeline to inline the vips WASM binary as a Base64 string during the webpack build process. This is part of the client-side media processing feature that enables image processing in the browser using WebAssembly.
Fixes #74421
Testing Instructions
Build Verification
packages/vips/build/contains output files with inlined Base64 WASM contentpackages/vips/build/index.cjs: