Conversation
|
Size Change: 0 B Total Size: 2.37 MB ℹ️ View Unchanged
|
12 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…ays result in active template
5e48416 to
029c1da
Compare
kmanijak
approved these changes
Oct 29, 2025
Contributor
kmanijak
left a comment
There was a problem hiding this comment.
PR fixes the template activation upon creating template via endpoint! 👍
PR made dozens of WooCommerce E2E tests to pass thanks to it
Member
Author
|
Thank you! |
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 29, 2025
…ays result in active template (#72770) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: kmanijak <karolmanijak@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: c7a8088 |
cbravobernal
pushed a commit
that referenced
this pull request
Nov 5, 2025
…ays result in active template (#72770) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: kmanijak <karolmanijak@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the release/22.0 branch to get it included in the next release: 36282e2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
To condition to distinguish between routes in
rest_pre_insert_wp_templateis wrong.Why?
We need to maintain backwards compatibility: all templates created through
/templatesshould automatically activate.How?
We should check the route instead.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast