DataViews: Use Text-Based Links for Primary Actions#72417
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -49 B (0%) Total Size: 2.2 MB
ℹ️ View Unchanged
|
I'm sorry, I changed the styles, a little bit and some of the screenshots used the old ones by mistake, I updated all screenshots. I'm not totally sure about which spacing is better but I'm open to any change there. |
|
I pushed some small changes:
The mobile experience is very awkward. We could switch to icon buttons, but I'm not sure it's worth it because as we add more actions in the future it's going to be very difficult to find icons to represent them all. On balance it might be simpler to hide primary actions on mobile (they're still accessible in the Acknowledgements/follow-ups
|
|
@tyxla what is going on with the |
Yeah, felt wrong to me too so I debugged. Looks like I had some plugins messing with the styles. It looks alright now, so no need to do anything there:
|
Agreed it is not that the actions look wrong but they take most of the space so other data becomes invisible. Moving the primary actions to the actions menu on mobile seems a good option to me. I will give it a try. |
That seems a simple improvement that could work well for some langua users and It is a simple change we can add. |
I think they're already there, so it's just a case of hiding primary actions on mobile. |
mtias
left a comment
There was a problem hiding this comment.
Let's get this in and try it. We may need to revise some wording (like "move to trash" > "delete") or move some actions to not be primary.
|
By the way, this should also reflect on the bulk editing footer actions area. |
|
Flaky tests detected in 47a8c49. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18648872692
|
18bca92 to
578a250
Compare
|
Following up with the bulk actions change. |
|
Very small PR at #72501 (I was not expecting things to work right away and for the PR to be so small, otherwise I would have had included the changes here) cc: @jameskoster. |
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org>
|
Cherry-picked to the |
|
I just cherry-picked this PR to the release/21.9 branch to get it included in the next release: 265e662 |
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org>




Replaces icon-only buttons with text-based links for primary actions in DataViews table and list layouts. Not all actions can possibly be represented as an icon so forcing an icon use at the framework level was an hard constraint. This also improves the accessibility of the application.
Testing
Screenshots