Block Comments: Avoid focus loss after creating a comment#72139
Merged
Block Comments: Avoid focus loss after creating a comment#72139
Conversation
6 tasks
|
Size Change: +114 B (+0.01%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e73c8d4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18333314368
|
Contributor
|
After a new comment is created, the comment thread will be in a "selected" state. Perhaps when a comment is opened (selected), That is, make the following changes to trunk: diff --git a/packages/editor/src/components/collab-sidebar/comments.js b/packages/editor/src/components/collab-sidebar/comments.js
index 1434cdae12..e5a3c732f5 100644
--- a/packages/editor/src/components/collab-sidebar/comments.js
+++ b/packages/editor/src/components/collab-sidebar/comments.js
@@ -124,6 +124,12 @@ function Thread( {
50
);
+ useEffect( () => {
+ if ( isSelected ) {
+ focusCommentThread( thread.id, commentSidebarRef.current );
+ }
+ }, [ isSelected, thread.id, commentSidebarRef ] );
+
const onMouseEnter = () => {
debouncedToggleBlockHighlight( thread.blockClientId, true );
}; |
Member
Author
|
In my experience, similar effects break easily. The Another option I'm considering is using |
e893221 to
e73c8d4
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Oct 8, 2025
Comment on lines
-47
to
-48
| await blockCommentUtils.addBlockWithComment( { | ||
| type: 'core/paragraph', |
Member
Author
There was a problem hiding this comment.
The addBlockWithComment also clears out snackbars, which steals the focus. Had to inline the comment creation logic.
Mamaduka
commented
Oct 8, 2025
Comment on lines
+129
to
+133
| // Stop trying after 3 seconds. | ||
| timer = setTimeout( () => { | ||
| observer.disconnect(); | ||
| resolve( null ); | ||
| }, 3000 ); |
Member
Author
There was a problem hiding this comment.
Not sure if we want to make this configurable. I guess it will work as a default value for now.
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
…72139) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: roseg43 <gabertronic@git.wordpress.org> Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71677.
Related #72024.
PR ensures the focus is moved to the newly created comment. I've also adjusted e2e tests to assert for focus.
Why?
When a new comment is created, focus is lost or returns to the page body, rather than remaining on the newly created comment.
Testing Instructions
Testing Instructions for Keyboard
Same.