Navigation Link, Navigation Submenu: Hide title UI controls while keeping attribute support#70234
Merged
t-hamano merged 2 commits intoMay 29, 2025
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Hi @t-hamano, I have opened the PR with the solution. Can you please review it at your convenience. |
Member
|
Note for the future: This is a follow-up to #69689. |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ping attribute support (WordPress#70234) * Revert the changes from PR WordPress#69689 * Remove title attribute from Controls in Navigation Link and Submenu blocks Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
titleattribute input field from the Navigation Link and Navigation Submenu block UI while maintaining full programmatic support. Users can no longer set the title through the WordPress editor interface, but the attribute remains functional when set via code editor, programmatic block creation, or existing content.Part of: #69663
How?
✅ title attribute still defined in block.json schemas
✅ Server-side rendering continues to output the title when present
Testing:
titleattributeScreencast:
Screen.Recording.2025-05-29.at.11.47.05.AM.mov