ToggleGroupControl: Fix active background for empty string value#69969
ToggleGroupControl: Fix active background for empty string value#69969
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @spstrap. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
- Is it worth backporting this PR into 6.8.x release? See #69925 (comment)
- I'm not sure why the component changelog entry check is failing, but the change log entry should have been added correctly.
Yes. It's not a major refactoring.
Same. It could be a problem with the workflow. I'll keep an eye on it. |
|
A backport PR for the |
) (#70000) Unlinked contributors: spstrap. Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: Sourav61 <sourav08@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
|
Removing the |
…dPress#69969) Unlinked contributors: spstrap. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Sourav61 <sourav08@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
What?
Closes #69925.
Similar to #66855.
PR fixes active
ToggleGroupControlOptionbackground when an empty string is provided, which seems to be a valid case, but was omitted from the check.Testing Instructions
Details
Testing Instructions for Keyboard
Same.
Screenshots or screencast