DataViews: Always show primary action for list layout if hover isn't supported#69876
Merged
t-hamano merged 1 commit intoApr 10, 2025
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Hi @t-hamano, Following up on our previous discussions, I've created a follow-up PR here. Could you please have a look when you get a moment? |
2c4ef46 to
61b6f16
Compare
t-hamano
approved these changes
Apr 10, 2025
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the follow-up.
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…supported (WordPress#69876) Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #69846
Related #69846 (review)
This PR ensures the primary action button is shown by default on screens that do not support the hover media query.
Why?
Primary Action Buttonaccessible on devices that do not supporthovermedia query.How?
The corresponding visibility styles were added within the
@media (hover: none)query.Testing Instructions
Primary Action, i.e.,Editis appropriately displayed.Testing Instructions for Keyboard
Same.
Screenshots