Size Change: -1 B (0%)

Total Size: 1.84 MB

_{compressed-size-action}

+1. I would like to avoid introducing new public APIs (props), this late in the release, especially now that LinkControl is no longer experimental.

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano, I think we should re-open #65458 or create a new issue and try to address the original a11y concerns.

Here are some problems with the original fix:

• Didn't account for hideLabelFromVision (partially fixed here).
• If placeholder is an empty string, the label will also be the empty string. Consumers might want to disable placeholders, but they should provide a label for a11y.

@Mamaduka Thanks for the review!

To follow up on this issue, I created a new issue: #69652

There was a conflict while trying to cherry-pick the commit to the wp/6.8 branch. Please resolve the conflict manually and create a PR to the wp/6.8 branch.

PRs to wp/6.8 are similar to PRs to trunk, but you should base your PR on the wp/6.8 branch instead of trunk.

# Checkout the wp/6.8 branch instead of trunk.
git checkout wp/6.8
# Create a new branch for your PR.
git checkout -b my-branch
# Cherry-pick the commit.
git cherry-pick 3bdadeba1bfe9bf86cbce572299f1655f24265c8
# Check which files have conflicts.
git status
# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue
# Push the branch to the repository
git push origin my-branch
# Create a PR and set the base to the wp/6.8 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

There was a conflict while trying to cherry-pick the commit to the wp/6.8 branch.

I would like to submit another PR for the wp/6.8 branch.

The backport PR fo the wp/6.8 branch: #69653

Thanks, @t-hamano!

Feel free to merge backport PR as soon as CI checks are green 🙌