Fix: Click-through blur effect when gallery images have a caption.#69067
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @CruelDrool. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
left a comment
There was a problem hiding this comment.
Sorry for the late reply.
The changes look good to me, but can you rebase this PR?
Additionally, is there a reason why you added cursor:pointer in addition to pointer-events:none?
fabfd09 to
82a82d3
Compare
|
Thanks for the review @t-hamano! 🙇🏻 I have rebased the PR
The element has |
|
I didn't see the difference between having |
|
On rechecking, agreed it doesn't add any visual change, apologies for the overlook 🙇🏻 |
…ordPress#69067) * Add pointer-events and cursor styles to gallery images * remove cursor pointer Unlinked contributors: CruelDrool. Co-authored-by: Rishit30G <rishit30g@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
Closes #69061
Why?
This PR is intended to resolve the issue which makes the blur effect block the image click
How?
This PR makes the following changes to the SCSS file:
This will help the cursor to appear on the blur part of the image and it will be clickable as well
Testing Instructions
Screenshots or screencast
PS: Sorry for the bad screen recording, my laptop's screen recorder wasn't able to show the
cursor: pointerbehaviour so had to rely on phone for recording 😓