Social links block: Add Clear button for color option#68564
Merged
carolinan merged 1 commit intoWordPress:trunkfrom Jan 10, 2025
shimotmk:fix/add-clear-button-to-social-links
Merged
Social links block: Add Clear button for color option#68564carolinan merged 1 commit intoWordPress:trunkfrom shimotmk:fix/add-clear-button-to-social-links
carolinan merged 1 commit intoWordPress:trunkfrom
shimotmk:fix/add-clear-button-to-social-links
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Hi @shimotmk is there an open issue related to this change? |
carolinan
approved these changes
Jan 10, 2025
Contributor
Author
|
@carolinan |
Mamaduka
approved these changes
Jan 10, 2025
Member
|
Thanks, @carolinan! I was about to merge this and then had to hop on a call 🙇 |
Contributor
Author
|
Thanks for the review! |
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
Add Clear buttons to the icon color and icon background color options on the social links block, to improve consistency with other options. Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
9 tasks
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Add Clear buttons to the icon color and icon background color options on the social links block, to improve consistency with other options. Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add a clear button just like the other color controls.
Similer #63580
Why?
Add a clear button for consistency
How?
Added clearable: true
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast