Skip to content

Block Card: Remove storybook for internal BlockCard component#68556

Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom
Infinite-Null:remove/block-card-internal-storybook
Jan 9, 2025
Merged

Block Card: Remove storybook for internal BlockCard component#68556
Mamaduka merged 1 commit intoWordPress:trunkfrom
Infinite-Null:remove/block-card-internal-storybook

Conversation

@Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Jan 9, 2025 •
edited
Loading

Related to: #67165

What?

Removes Storybook documentation for the internal BlockCard component.

Why?

According to recent discussions, internal components that are not intended for public use should not be exposed in Storybook. This keeps our Storybook documentation focused on components that are actually useful for WordPress extenders and makes the documentation more maintainable.

Testing Instructions

  • Run npm run storybook:dev
  • Open Storybook at http://localhost:50240/

@github-actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Infinite-Null
Copy link
Contributor Author

Infinite-Null commented Jan 9, 2025

Hi @t-hamano,

According to this comment internal components should not be exposed in Storybook as they are not intended for use by WordPress extenders. Given that BlockCard is an internal component,This PR removes Storybook documentation to align with this direction.

Please review it at your convenience. Thank You!

@Infinite-Null Infinite-Null mentioned this pull request Jan 9, 2025
Open
@Mamaduka Mamaduka added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components props-bot Manually triggers Props Bot to ensure the list of props is up to date. labels Jan 9, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jan 9, 2025
@Mamaduka Mamaduka added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jan 9, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jan 9, 2025
@Mamaduka Mamaduka merged commit 85d9bad into WordPress:trunk Jan 9, 2025
75 of 76 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 9, 2025
Gulamdastgir-Momin pushed a commit to Gulamdastgir-Momin/gutenberg that referenced this pull request Jan 23, 2025
@Infinite-Null @Mamaduka @Gulamdastgir-Momin
Remove storybook for internal BlockCard component (WordPress#68556)
78fb5bd 
Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees

No one assigned

Labels

Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

Gutenberg 20.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Infinite-Null @Mamaduka