Storybook: Add story for the Warning component #68124
Storybook: Add story for the Warning component #68124t-hamano merged 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hey @t-hamano, Could you please review my PR for adding the story for the Warning component? I used the README.md as a solid reference to create the story. Looking forward to your feedback! |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I think it's important for this component to show how the actions prop and secondaryActions prop are displayed. For example, see the story of the Notice component. For example, you should be able to define multiple stories like this:
export const WithActions = {
args: {
...Default.args,
actions: [
<Button key="fix-issue" __next40pxDefaultSize variant="primary">
{ __( 'Fix issue' ) }
</Button>,
],
},
};
export const WithSecondaryActions = {
args: {
...Default.args,
secondaryActions: [
{ title: __( 'Get help' ) },
{ title: __( 'Remove block' ) },
],
},
};
packages/block-editor/src/components/warning/stories/index.story.js
Outdated
Show resolved
Hide resolved
|
@t-hamano , Please check again; I have made the requested changes. Screen.Recording.2024-12-23.at.6.02.57.PM.mov |
* doc: Add storybook for warning component * feat: Add story with actions, and secondary actions Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Part of #67165
What?
This PR adds the Storybook stories for the Warning component in the block editor.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-12-19.at.2.03.53.PM.mov