Storybook: Add TabbedSidebar stories and improve docs#68118
Storybook: Add TabbedSidebar stories and improve docs#68118t-hamano merged 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @t-hamano 👋 I've added Storybook stories for TabbedSidebar and updated its documentation. Would appreciate your review when you have a moment. Thank you! |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR! I also think the typo fixes and improvements in the README are great.
packages/block-editor/src/components/tabbed-sidebar/stories/index.story.js
Show resolved
Hide resolved
packages/block-editor/src/components/tabbed-sidebar/stories/index.story.js
Outdated
Show resolved
Hide resolved
|
Thank you for the feedback. I've updated the PR accordingly. |
There was a problem hiding this comment.
Thanks for the update! Finally, it's a good idea to make some props controllable:
diff --git a/packages/block-editor/src/components/tabbed-sidebar/stories/index.story.js b/packages/block-editor/src/components/tabbed-sidebar/stories/index.story.js
index ec4621ced7..49825be19b 100644
--- a/packages/block-editor/src/components/tabbed-sidebar/stories/index.story.js
+++ b/packages/block-editor/src/components/tabbed-sidebar/stories/index.story.js
@@ -55,7 +55,7 @@ const meta = {
description: 'The ID of the currently selected tab.',
},
tabs: {
- control: { type: null },
+ control: { type: 'array' },
table: {
type: { summary: 'array' },
},
@@ -63,7 +63,7 @@ const meta = {
'Array of tab objects. Each tab should have: name (string), title (string), panel (React.Node), and optionally panelRef (React.Ref).',
},
closeButtonLabel: {
- control: { type: null },
+ control: { type: 'text' },
table: {
type: { summary: 'string' },
},
|
Thanks for the feedback! I've updated the PR accordingly. |
* Add stories and improve TabbedSidebar docs * Refactor TabbedSidebar story * Make TabbedSidebar story props controllable Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
* Add stories and improve TabbedSidebar docs * Refactor TabbedSidebar story * Make TabbedSidebar story props controllable Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Part of: #67165
What?
This PR will add stories for TabbedSidebar component in the Storybook.
Testing Instructions
Screenshots or screencast