Fix don't show inserter in Zoom Out dropzone when the text is visible#68031
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +51 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Dec 17, 2024
MaggieCabrera
left a comment
Contributor
There was a problem hiding this comment.
This LGTM, tests ok and the code makes sense
| const nextClientId = blockOrder[ insertionIndex ]; | ||
|
|
||
| // if the block insertion point is visible, and the insertion | ||
| // indicies match then we don't need to render the inserter. |
Contributor
There was a problem hiding this comment.
Suggested change
| // indicies match then we don't need to render the inserter. | |
| // indices match then we don't need to render the inserter. |
Super nit
Contributor
Author
There was a problem hiding this comment.
Missed this one. Apologies
Contributor
Author
There was a problem hiding this comment.
@MaggieCabrera Please can you approve #68051
mikachan
reviewed
Dec 17, 2024
Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
|
Flaky tests detected in d31f0df. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12372755704
|
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…WordPress#68031) * Hide inserter * Comment case Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com> --------- Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…WordPress#68031) * Hide inserter * Comment case Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com> --------- Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Hides the inserter
+when the zoom out dropzone is renderedCloses #67568
Why?
Because otherwise - as per the Issue - we get the inserter rendered on top of the drop zone text in Zoom Out.
How?
Conditionally displayed the inserter only when the current insertion index doesn't match the targetted insertion index for the inserter being rendered.
Testing Instructions
+inserter+Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-12-16.at.14-37-20.mp4