Pages: remove unnecessary padding for items#67977
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +31 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e0879ad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12315372760
|
Member
|
Good catch. Would this fix also a similar issue for the Navigation panel items? Screenshot:
|
Member
Author
No, that's a different thing. The change here only affects screens that use the |
Contributor
|
This also affects the custom view buttons, making the ellipsis a bit too close to the edge of the container. 
But these buttons are already a bit broken, and experimental, so perhaps it's okay? |
Member
Author
Pushed 2b5bd7b that scopes the padding to custom items. |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Note how the outer focus ring doesn't wrap the whole item:
Why?
In any other site editor screen, the focus style for the list item takes the whole item.
How?
Remove unnecessary padding rule.
Testing Instructions
Go to the Pages screen in the site editor and focus one of the items with the keyboard. Verify the outer ring wraps the whole item.