Improve logic to show entities saved panel description.#67971
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +7 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Dec 13, 2024
Mamaduka
left a comment
Member
There was a problem hiding this comment.
I just left a minor note. The logic change works as expected ✅
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Member
Author
|
@Mamaduka thanks for your review. Applied your suggestion and waiting for tests to pass before hitting the green button. |
t-hamano
approved these changes
Dec 13, 2024
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix. Certainly, when we try to activate a theme that has not had any changes made to it, that text should not be displayed.
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67963
What?
The Theme Preview save panel shows a description
Select the items you want to save.even when there are no change items to save.Why?
The message is confusing and the logic to show it should be improved.
How?
Shows the message only when there are actual dirty entities records to save.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast