Skip to content

Date Block: Refactor settings panel to use ToolsPanel#67906

Merged
fabiankaegy merged 1 commit into
WordPress:trunkfrom
Sukhendu2002:refactor/date-block-settings-panel
Dec 13, 2024
Merged

Date Block: Refactor settings panel to use ToolsPanel#67906
fabiankaegy merged 1 commit into
WordPress:trunkfrom
Sukhendu2002:refactor/date-block-settings-panel

Conversation

@Sukhendu2002

@Sukhendu2002 Sukhendu2002 commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

Part of: #67813

What?

Refactored Date Block code to include ToolsPanel instead of PanelBody.

Screenshots or screencast

Before After
image image

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review December 13, 2024 06:10
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Post Date Affects the Post Date Block labels Dec 13, 2024

@fabiankaegy fabiankaegy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected :) Thanks so much 🚀

CleanShot.2024-12-13.at.09.16.49.mp4

@fabiankaegy fabiankaegy merged commit cbe7ef4 into WordPress:trunk Dec 13, 2024
@github-actions github-actions Bot added this to the Gutenberg 20.0 milestone Dec 13, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…PanelBody (WordPress#67906)

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…PanelBody (WordPress#67906)

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Post Date Affects the Post Date Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Date block to use ToolsPanel instead of PanelBody

2 participants