Fix hiding and showing of meta boxes#67504
Merged
cbravobernal merged 1 commit intotrunkfrom Dec 4, 2024
Merged
Conversation
This was referenced Dec 3, 2024
|
Size Change: +3 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
cbravobernal
approved these changes
Dec 4, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Contributor
|
This code is already on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A fix for a bug introduced in #67254.
Why?
Toggling visibility of meta boxes is broken. They are visible even if their switched off in Preferences (if at least one other is visible).
How?
Fixes the
useSelectusage to correct what was a blatant mistake.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Demonstration of the broken behavior on trunk:
meta-boxes-broken-hide-show.mp4