ToolbarButton: Set size to "compact"#67440
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Dec 2, 2024
tyxla
left a comment
Member
There was a problem hiding this comment.
No visual changes for either variants 👍
Member
|
Any chance this PR resulted in this regression? When selecting a template part from editing a page.
|
Member
Author
|
@richtabor Thanks for flagging! Addressed in #67502 |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
* ToolbarButton: Set size to "compact" * Add changelog * Update snapshots Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
* ToolbarButton: Set size to "compact" * Add changelog * Update snapshots Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for #65751
What?
Add a
size="compact"to the internalButtonused inToolbarButton.Why?
The size styles are largely overridden by ToolbarButton, but this size variant is closest to what is intended. This PR is mostly just to prevent breakage when the Button size default changes to 40px. There should be no visual changes.
Testing Instructions
See the Storybook stories for Toolbar. There should be no visual changes, including changes in focus indicators or click target sizes.
There are two internal implementation "variants" in the ToolbarButton — flip this logic to check both:
gutenberg/packages/components/src/toolbar/toolbar-button/index.tsx
Line 51 in 9ffbd9c