Skip to content

Composite: Restore Hover and Typeahead functionality#67212

Merged
mirka merged 4 commits intotrunkfrom
fix/composite-typeahead
Nov 22, 2024
Merged

Composite: Restore Hover and Typeahead functionality#67212
mirka merged 4 commits intotrunkfrom
fix/composite-typeahead

Conversation

@mirka
Copy link
Copy Markdown
Member

@mirka mirka commented Nov 21, 2024 •
edited
Loading

Fixes #67152

What?

Restores functionality of Composite.Hover and Composite.Typeahead.

How?

Due to a copy paste error in #65821, Typeahead functionality was lost and replaced with a CompositeRow, as well as Hover with CompositeGroup 😄

Testing Instructions

See repro instructions in #67152.

@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Nov 21, 2024
@mirka mirka self-assigned this Nov 21, 2024
@mirka mirka requested a review from ajitbohra as a code owner November 21, 2024 17:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 21, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka mentioned this pull request Nov 21, 2024
Closed
mirka
mirka commented Nov 21, 2024
View reviewed changes
packages/components/src/composite/hover.tsx
const store = ( props.store ?? context.store ) as Ariakit.CompositeStore;

return <Ariakit.CompositeGroup store={ store } { ...props } ref={ ref } />;
return <Ariakit.CompositeHover store={ store } { ...props } ref={ ref } />;
Copy link
Copy Markdown
Member Author

@mirka mirka Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol another one

@mirka mirka changed the title Composite.Typeahead: Restore functionality Composite: Restore Hover and Typeahead functionality Nov 21, 2024
@mirka mirka requested review from a team and t-hamano November 21, 2024 17:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 21, 2024

Flaky tests detected in 9a319a3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11958943827
📝 Reported issues:

@t-hamano t-hamano mentioned this pull request Nov 22, 2024
Closed
t-hamano
t-hamano approved these changes Nov 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have confirmed that both the up and down keyboard navigation and type-ahead functions work correctly.

Before

before.mp4

After

after.mp4

@t-hamano
Copy link
Copy Markdown
Contributor

t-hamano commented Nov 22, 2024

I think this PR is worth backporting to 6.7.2, so I'm adding the "Backport to WP Minor Release" label.

cc @cbravobernal

@t-hamano t-hamano added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Nov 22, 2024
@mirka mirka enabled auto-merge (squash) November 22, 2024 22:01
@mirka mirka merged commit 02611cb into trunk Nov 22, 2024
@mirka mirka deleted the fix/composite-typeahead branch November 22, 2024 22:05
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 22, 2024
cbravobernal added a commit that referenced this pull request Nov 24, 2024
@mirka @t-hamano
@cbravobernal @jameskoster
Composite: Restore Hover and Typeahead functionality (#67212)
d01c825 
* Composite.Typeahead: Restore functionality

* Add changelog

* Resurrect CompositeHover

* Update changelog

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
@ciampo
Copy link
Copy Markdown
Contributor

ciampo commented Nov 25, 2024

Lol. Thank you for having my back 🙏

cbravobernal added a commit that referenced this pull request Nov 25, 2024
@cbravobernal @mirka
@t-hamano @jameskoster
Composite: Restore Hover and Typeahead functionality - Backport to 6.…
9137a9f 
…7.2 (#67258)

* Composite: Restore `Hover` and `Typeahead` functionality (#67212)

* Composite.Typeahead: Restore functionality

* Add changelog

* Resurrect CompositeHover

* Update changelog

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

* Update changelog

* Fix changelog

---------

Co-authored-by: Lena Morita <lena@jaguchi.com>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: Aki Hamano <tetsuaki.hamano@gmail.com>
@t-hamano
Copy link
Copy Markdown
Contributor

t-hamano commented Apr 23, 2025

Removing Backport to WP Minor Release label because #67258, which is equal to this PR, has already been merged into wp/6.7 branch.

@t-hamano t-hamano removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@mirka mirka

Labels

[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

No open projects
WordPress 6.7.x Editor Tasks
Status: ✅ Done

Milestone

Gutenberg 19.8

Development

Successfully merging this pull request may close these issues.

DataViews: Keyboard navigation in filter configuration listbox is broken

3 participants

@mirka @t-hamano @ciampo