Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
approved these changes
Oct 31, 2024
Contributor
jasmussen
left a comment
There was a problem hiding this comment.
Seems to work for me, though I'd appreciate a gut-check from @stokesman.
|
Size Change: +14 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
stokesman
approved these changes
Oct 31, 2024
Contributor
stokesman
left a comment
There was a problem hiding this comment.
I tested and confirm it works. The change makes sense. Thank you for the quick fix!
andrewserong
reviewed
Nov 1, 2024
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
I just noticed a regression on trunk with the position of the appender on an empty document, that appears to be introduced here. I've added a couple of comments in case that helps figure out what the right fix would be!
Comment on lines
-68
to
-77
| .block-editor-default-block-appender .block-editor-inserter { | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| line-height: 0; | ||
|
|
||
| &:disabled { | ||
| display: none; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I think this removal appears to have caused a regression for the default block appender as it no longer appears to the right of the "fake" empty paragraph before a user interacts with the editor:
Before this PR
After this PR
Comment on lines
+60
to
+62
| // The black plus that shows up on the right side of an empty paragraph block, | ||
| // or the initial appender that exists only on empty documents. | ||
| .block-editor-block-list__empty-block-inserter.block-editor-block-list__empty-block-inserter { |
Contributor
There was a problem hiding this comment.
the initial appender that exists only on empty documents.
In an empty document the classnames in use for the default appender appear to be .block-editor-default-block-appender .block-editor-inserter. Was that rule removed intentionally when moving to this separate file?
Also, it looks like the markup for the default block appender is rendered inside the iframe rather than outside it — so we might still need that rule in content.scss, unless there's another way to go about this. Here's where the default appender lives:
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A misplaced CSS rule was uncovered by #66432 (comment).
Currently, the CSS rule that targets the empty-paragraph inserter is placed in the block editor's
content.cssfile rather than itsstyle.css, even though the empty-paragraph inserter is a popover that is rendered outside the canvas. Only block list appenders are rendered inside the canvas.This was not an issue before #66432, because we were rendering all the content styles outside the iframe too!
Why?
Fixes #66432 (comment).
How?
Move the rule that targets the popover to the appropriate stylesheet.
Testing Instructions
The change in #66432 only affects the Site Editor.
Testing Instructions for Keyboard
Screenshots or screencast