Block editor: exclude wp- styles from iframe compat styles#66628
Merged
Block editor: exclude wp- styles from iframe compat styles#66628
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -13 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 31, 2024
Contributor
|
I just cherry-picked this PR to the release/19.6 branch to get it included in the next release: 04d57ce |
cbravobernal
pushed a commit
that referenced
this pull request
Nov 4, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…#66628) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66556 (comment).
This PR skips over
wp-core styles when looking for "compatibility" styles (that contain rules that target the canvas).Not only does this fix the warning, but it should also speed up load a tiny bit because there's less styles to parse.
Why?
Because we are responsible for adding our own styles to the iframed canvas. Note that we would be seeing warnings for all the styles not added, so we know that all of them are correctly added.
How?
We skip them.
Testing Instructions
Load the site editor and make sure there's no compat styles warning.
Testing Instructions for Keyboard
Screenshots or screencast