Skip to content

Post Content: Add border and spacing support#66366

Merged
tellthemachines merged 3 commits intoWordPress:trunkfrom
rinkalpagdar:add/post-content-border
Nov 6, 2024
Merged

Post Content: Add border and spacing support#66366
tellthemachines merged 3 commits intoWordPress:trunkfrom
rinkalpagdar:add/post-content-border

Conversation

@rinkalpagdar
Copy link
Contributor

@rinkalpagdar rinkalpagdar commented Oct 23, 2024 •
edited
Loading

What?

Add border block support to the post content block.
Part of #43247
Part of #43243

Why?

The post content block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  1. Go to the Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  2. Make sure that the content block's border is configurable via Global Styles
  3. Verify that Global Styles are applied correctly in the editor and frontend
  4. Edit the post, Add content block and Apply the border styles
  5. Verify that block styles take precedence over global styles
  6. Verify that block borders display correctly in both the editor and frontend

Screenshots or screencast

post-content-border

@github-actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 23, 2024
@github-actions
Copy link

github-actions bot commented Oct 23, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rinkalpagdar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Post Content Affects the Post Content Block labels Oct 23, 2024
@rinkalpagdar rinkalpagdar changed the title border added to post content block Post Content: Add border and spacing support Oct 24, 2024
This was referenced Oct 24, 2024
Open
Open
tellthemachines
tellthemachines reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's working well for me in testing. Could you just revert the whitespace changes in block.json?

@rinkalpagdar
Copy link
Contributor Author

rinkalpagdar commented Nov 6, 2024

@tellthemachines Thanks for the feedback. I have reverted the spacing in block.json.

tellthemachines
tellthemachines approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM now!

@tellthemachines tellthemachines merged commit b252874 into WordPress:trunk Nov 6, 2024
@github-actions github-actions bot added this to the Gutenberg 19.7 milestone Nov 6, 2024
@tellthemachines tellthemachines mentioned this pull request Nov 6, 2024
Open
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
@rinkalpagdar @tellthemachines @karthick-murugan
Post Content: Add border and spacing support (WordPress#66366)
52ba1ab 
Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
@zzap zzap mentioned this pull request Apr 9, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tellthemachines tellthemachines tellthemachines approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego

Assignees

@rinkalpagdar rinkalpagdar

Labels

[Block] Post Content Affects the Post Content Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 19.7

Development

Successfully merging this pull request may close these issues.

3 participants

@rinkalpagdar @tellthemachines @akasunil