Add argument with post ID to the editor.savePost hook#66165
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4d00f18. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11363399213
|
tyxla
approved these changes
Oct 16, 2024
Member
tyxla
left a comment
There was a problem hiding this comment.
Makes sense, thanks! 👍
Good timing 😅 a few more weeks and it would have been too late.
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 16, 2024
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: b59bac3 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing the dev note for the
editor.savePostaction, I noticed it has a serious problem: the identity of the saved post (the ID and optionally other fields) is not passed to the action at all. The handler doesn't know anything about the post it's dealing with. It gets only theoptions, which contain flags likeisAutosaveandisPreviewand nothing more.This PR fixes that by adding a first argument, and object with the
idfield. The goal is mainly to be forward compatible:postargument extensible in the future. It's an object that currently contains theidfield, and it the future it can have more fields.The
editor.preSavePosthas a similar API already: first argument isedits, an object which includes theidfield, and the second argument is theoptions.We got to this situation because originally the hook was motivated by the "save metaboxes" action. And accidentally, the "save metaboxes" doesn't need to know the post ID, because it can read it from the metabox forms inside the page HTML. But other users of the hook are likely to run into big trouble very soon.