Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kevin940726
reviewed
Oct 16, 2024
| margin-bottom: $grid-unit-10; | ||
| box-shadow: none; | ||
| outline: none; | ||
| border-radius: $radius-small; // Todo: revisit when applying the radius scale to the block toolbar |
Member
There was a problem hiding this comment.
Thank you for adding a comment ❤️!
jasmussen
approved these changes
Oct 16, 2024
Contributor
jasmussen
left a comment
There was a problem hiding this comment.
Good catch. Not sure we need the todo, to an extent all the block toolbars could use a substantial refactor. :)
|
Size Change: +24 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Fair point, I'll remove. |
ciampo
reviewed
Oct 16, 2024
Contributor
There was a problem hiding this comment.
The code changes do achieve the desired result, but the amount of overrides needed to achieve the desired look makes me uncomfortable — we're just piling up more overrides / tech debt on top of existing one.
We may need to rethink the design rules of popovers / toolbars:
- as a rule of thumb, consumers of
Popovershould not overridecomponents-popover__content. They should, instead, render their own wrapper element and add styles to it. - Given how generic
Popoveris, I'm not sure it makes sense to add a border radius to popover content if we then have to override it; - same for the overrides to
box-shadowandoutline. Ideally, we should just useToolbarout of the box, without the need for special overrides
Can we identify the friction that causes the overrides, and work towards removing it?
Member
Contributor
Author
|
Yes I'm not comfortable about the overrides either, but fixing the issue for 6.7 seems most important right now. Like Joen said the Toolbar, Block Toolbar, and all other overlapping components probably need a holistic audit. |
Contributor
|
Absolutely, I'm not against merging this PR — I just wanted to put emphasis on the need for reviewing styles of popovers/toolbars |
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 16, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 86038c4 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix appearance of corners in rich text toolbars.
Why?
See #66134. Closes #66134.
How?
Mimics the technique used in the Block toolbar component. Ideally we revisit and fix this in the WP Components / Toolbar. But for 6.7 this seems acceptable to me.
Testing Instructions
Before
After