Fix: Add missing post.slug dependency to useMemo#66125
Merged
SantosGuillamot merged 1 commit intotrunkfrom Oct 15, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
While running the linter, I realized that there are no dependencies in this useLayoutEffect. Should we add dependencies there or is it okay for |
youknowriad
approved these changes
Oct 15, 2024
Contributor
|
That useLayoutEffect is more sensitive. I think adding dependencies there will break a lot of things. There are things to improve there but it's not as simple as adding the deps. |
|
Size Change: +2 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b6538df. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11348097846
|
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 15, 2024
- Add missing `post.slug` dependency to `useMemo` Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: f939558 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
- Add missing `post.slug` dependency to `useMemo` Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
As reported here by @youknowriad , there is a missing dependency in the
useMemohook.Why?
It can cause unexpected bugs.
How?
Add the missing dependency to the hook.