Revert the "Manage fonts" button in Global Styles#66107
Merged
Conversation
|
Size Change: +199 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Oct 14, 2024
Member
ramonjd
left a comment
There was a problem hiding this comment.
✅ "Manage fonts" button only displays when there are no active fonts.
✅ If there are no fonts installed, the button will read "Add fonts".
✅ Otherwise, the button doesn't show
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
Is this just a revert commit of #62129? I see a |
Contributor
|
Note: for better process, I added the same GitHub labels from the original issue and PR that implemented this change. |
1 similar comment
Contributor
|
Note: for better process, I added the same GitHub labels from the original issue and PR that implemented this change. |
Contributor
Actually, this is not a revert. It's a change. |
t-hamano
approved these changes
Oct 15, 2024
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
There is still discussion going on about the button layout so like #65590 I think it would be best to revert to the previous state in WP 6.7.
I see a
style.scsschange in the original PR, should we include that here too?
The current stylesheet matches this PR perfectly, so I don't think any stylesheet changes are necessary.
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 15, 2024
Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: d360fd1 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65574
What?
This PR reverts the "Manage fonts" button that was persistently displayed when managing fonts in the Global Styles → Typography. Now, this "Manage fonts" button only displays when there are no active fonts. If there are no fonts installed, the button will read "Add fonts". This behavior is similar to 6.6.
Why?
There is an open discussion about whether this button should be displayed. As we are approaching the 6.7 release, the release leads agreed to revert to 6.6 functionality and continue this discussion for future Gutenberg releases.