Conversation
|
Size Change: +968 B (+0.05%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
3cd9a76 to
032182e
Compare
c7b94b2 to
2874f35
Compare
79365b4 to
36561f8
Compare
ramonjd
left a comment
There was a problem hiding this comment.
Another fly by test.
I think this is in a very good place. Awesome work.
I couldn't perceive any performance regressions - clicking between tabs is snappy.
Also the colors updates on all style changes. That the colors/gradients don't open their respective tabs in the panel isn't a problem for the first round I reckon.
36561f8 to
92dbe8f
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for keeping an eye on this @ramonjd, very much appreciated 🙇 I've finally had a chance to chip away at the last few rough edges. So if you're happy regarding the general direction as an MVP for the Style Book color tab, I am. In that spirit, I've flagged this for a proper review. |
|
Flaky tests detected in 4d4a095. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11453617073
|
ramonjd
left a comment
There was a problem hiding this comment.
Fantastic work @aaronrobertshaw . I think this is good to go as a first version.
Pretty snappy and the real-time updates for custom colors/gradients are 💯
Kapture.2024-10-22.at.15.35.47.mp4
|
Thanks for the review and testing @ramonjd 🚀 I'll get the conflict resolved and merge. |
…xample" This reverts commit eb74467.
4103d7f to
4d4a095
Compare
This reverts commit 5437114.
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Part of:
Depends on:
What?
Adds a "Color" tab to the Style Book.
Why?
An important aspect of a theme's styles are its available colors, gradients, and duotone filters. The proposed color tab for the style book provides a means through which these can be displayed alongside other global styles for blocks.
See #53431 for further context.
How?
examples.tstoexamples.tsxand adds/updates utils for generating color tab examplesTesting Instructions
To save some extra configuration to see all the various types of color examples activate a theme such as TT2 that defines not only color palettes but also duotones, gradients, and keeps default palettes enabled.
Screenshots or screencast
Screen.Recording.2024-10-16.at.5.48.03.pm.mp4