Fix: Add soft deperecation notice for the ButtonGroup component#65429
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Let's wait before reviewing / merging this one until all usages of |
mirka
left a comment
There was a problem hiding this comment.
We're finally ready to proceed with this one!
Please also add a changelog 🙏
|
Hi @mirka, All the feedbacks have been addressed in the PR and also added the changelog for the soft deprecation. Let me know if we need to change wordings for deprecation message? Thank You, |
…Press#65429) * Add deperecation notice for the ButtonGroup component * Address the feedbacks for deprecation for ButtonGroupControl * Add the changelog deprecation message. * Update the changelog comment Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
…Press#65429) * Add deperecation notice for the ButtonGroup component * Address the feedbacks for deprecation for ButtonGroupControl * Add the changelog deprecation message. * Update the changelog comment Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
What?
Issue - #65338
Why?
ToggleGroupControl, so need to deprecate theButtonGroupas no more needed.How?
@deprecateon JS Doc.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
✍️ Dev Note
The
ButtonGroupcomponent has been deprecated, as it can easily lead to accessibility issues. For simpler adherence to accessibility best practices and to be consistent with the current WordPress design system, useToggleGroupControlinstead.